Re: [PATCH v1 1/5] dt-bindings: power: Add bindings for a power domain controlled by a regulator

From: Krzysztof Kozlowski
Date: Wed Jun 15 2022 - 13:16:43 EST


On 15/06/2022 08:19, Max Krummenacher wrote:
> Hi
>
> On Fri, Jun 10, 2022 at 4:57 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>>
>> On Thu, 09 Jun 2022 17:08:47 +0200, Max Krummenacher wrote:
>>> From: Max Krummenacher <max.krummenacher@xxxxxxxxxxx>
>>>
>>> Adds binding for a power domain provider which uses a regulator to control
>>> the power domain.
>>>
>>> Signed-off-by: Max Krummenacher <max.krummenacher@xxxxxxxxxxx>
>>> ---
>>>
>>> .../power/regulator-power-domain.yaml | 58 +++++++++++++++++++
>>> 1 file changed, 58 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/power/regulator-power-domain.yaml
>>>
>>
>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
>> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/regulator-power-domain.example.dtb: power-sleep-moci: $nodename:0: 'power-sleep-moci' does not match '^(power-controller|power-domain)([@-].*)?$'
>> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/regulator-power-domain.yaml
>
> Will change to 'power-domain-sleep-moci' in V2.
>

Instead: power-domain
(names should be generic)


Best regards,
Krzysztof