Re: [PATCH v3 13/17] PCI: dwc: Introduce generic controller capabilities interface

From: Rob Herring
Date: Wed Jun 15 2022 - 12:43:34 EST


On Fri, Jun 10, 2022 at 11:57:01AM +0300, Serge Semin wrote:
> Since in addition to the already available iATU unrolled mapping we are
> about to add a few more DW PCIe platform-specific capabilities (CDM-check
> and generic clocks/resets resources) let's add a generic interface to set
> and get the flags indicating their availability. The new interface shall
> improve maintainability of the platform-specific code.
>
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
>
> ---
>
> Note the DW_PCIE_CAP_IATU_UNROLL macro is intentionally set to 1 since
> being added afterwards capability will be more suitable to be identified
> with position 0.
>
> Changelog v3:
> - This is a new patch created on v3 lap of the series.
> ---
> drivers/pci/controller/dwc/pcie-designware.c | 11 ++++++-----
> drivers/pci/controller/dwc/pcie-designware.h | 12 +++++++++++-
> 2 files changed, 17 insertions(+), 6 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>