Re: [PATCH] arch: x86: kernel: Add missing of_node_put() in devicetree.c

From: Dave Hansen
Date: Wed Jun 15 2022 - 11:33:41 EST


On 6/15/22 08:03, Liang He wrote:
> In dtb_setup_hpet(), of_find_compatible_node() will return a node
> pointer with refcount incremented. We should use of_node_put() when it
> is not used anymore.
>
> Signed-off-by: Liang He <windhl@xxxxxxx>

Seems like:

Fixes: ffb9fc68dff3 ("x86: dtb: Add device tree support for HPET")

and would be appropriate, right?

Also, how was this found, and what is the impact from not fixing it?
Was it causing horrible problems in production, or was it just something
that was found by inspection that's not causing any real problems in
practice?