Re: [PATCH -next] dmaengine: apple-admac: Fix build on 32-bit/non-LPAE platforms

[Martin Povišer]

> On 14. 6. 2022, at 9:49, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> 
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
> 
>    drivers/dma/apple-admac.c: In function ‘admac_cyclic_write_one_desc’:
>    drivers/dma/apple-admac.c:213:22: error: right shift count >= width of type [-Werror=shift-count-overflow]
>      213 |  writel_relaxed(addr >> 32,       ad->base + REG_DESC_WRITE(channo));
>          |                      ^~
> 
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain the
> address parts.
> 
> Reported-by: noreply@xxxxxxxxxxxxxx
> Fixes: b127315d9a78c011 ("dmaengine: apple-admac: Add Apple ADMAC driver")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

Thanks! (TIL about the lower/upper_32_bits helpers)

Acked-by: Martin Povišer <povik+lin@xxxxxxxxxxx>