Re: [PATCH v8] can, tty: can327 CAN/ldisc driver for ELM327 based OBD-II adapters

From: Marc Kleine-Budde
Date: Wed Jun 15 2022 - 03:33:37 EST


Hello Max!

On 12.06.2022 17:56:54, Marc Kleine-Budde wrote:
> > diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
> > index 9d0f06bfbac3..68aeae2addec 100644
> > --- a/include/uapi/linux/tty.h
> > +++ b/include/uapi/linux/tty.h
> > @@ -38,8 +38,9 @@
> > #define N_NULL 27 /* Null ldisc used for error handling */
> > #define N_MCTP 28 /* MCTP-over-serial */
> > #define N_DEVELOPMENT 29 /* Manual out-of-tree testing */
> > +#define N_CAN327 30 /* ELM327 based OBD-II interfaces */
> >
> > /* Always the newest line discipline + 1 */
> > -#define NR_LDISCS 30
> > +#define NR_LDISCS 31
> >
> > #endif /* _UAPI_LINUX_TTY_H */
>
> Greg, do you want the include/uapi/linux/tty.h changes in a separate
> patch and upstream it?

Please make this a separate patch and send it to Greg similar to the
N_DEVELOPMENT patch.

Once this change is in net-next/master I'll merge the can327 driver.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: PGP signature