Re: [PATCH v3 03/10] scsi: ufs-mediatek: Introduce workaround for power mode change

From: Stanley Chu
Date: Tue Jun 14 2022 - 23:49:49 EST


On Tue, 2022-06-14 at 09:46 -0700, Bart Van Assche wrote:
> On 6/14/22 07:16, Stanley Chu wrote:
> > + if ((dev_req_params->pwr_tx != FAST_MODE) &&
> > + (dev_req_params->gear_tx < UFS_HS_G4))
> > + return false;
> > +
> > + if ((dev_req_params->pwr_rx != FAST_MODE) &&
> > + (dev_req_params->gear_rx < UFS_HS_G4))
> > + return false;
>
> Please do not use more parentheses than needed. I think 8
> parentheses
> can be left out from the above code.

Thanks! fixed in v4.

>
> Thanks,
>
> Bart.