Re: [PATCH RESEND] Add a "-m" option to "perf buildid-list".

[Blake Jones]

On Tue, Jun 14, 2022 at 5:29 AM Jiri Olsa <olsajiri@xxxxxxxxx> wrote:
> still there's kernel map included, so it's strange to me call it modules
>
>   --m/--kernel-maps ?

Sure, I'll go with that.

> > > also please state that it's from running kernel
> >
> > Happy to make this change.
> >
> > > any reason why not use the dso fields directly?
> >
> > I was just following my general software engineering instincts to
> > encapsulate implementation details, so that e.g. the caller doesn't need to
> > know about details such as the "has_build_id" boolean. I haven't made
> > changes to perf before, so if that's not the preferred style, I can do it
> > a different way.
>
> we have some helpers for dso fields, but AFAICS long_name and has_build_id
> are used directly all over the place

Okay, I've switched the code over to use those fields directly.

New patch coming shortly.

Blake