Re: [PATCH] KVM: x86: Query vcpu->vcpu_idx directly and drop its accessor, again

[Jim Mattson]

On Tue, Jun 14, 2022 at 3:56 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> Read vcpu->vcpu_idx directly instead of bouncing through the one-line
> wrapper, kvm_vcpu_get_idx(), and drop the wrapper.  The wrapper is a
> remnant of the original implementation and serves no purpose; remove it
> (again) before it gains more users.
>
> kvm_vcpu_get_idx() was removed in the not-too-distant past by commit
> 4eeef2424153 ("KVM: x86: Query vcpu->vcpu_idx directly and drop its
> accessor"), but was unintentionally re-introduced by commit a54d806688fe
> ("KVM: Keep memslots in tree-based structures instead of array-based ones"),
> likely due to a rebase goof.  The wrapper then managed to gain users in
> KVM's Xen code.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

ROFL

Reviewed-by: Jim Mattson <jmattson@xxxxxxxxxx>