Re: [PATCH] media: mediatek: vcodec: fix minmax.cocci warning

[Nicolas Dufresne]

Le mardi 14 juin 2022 à 15:25 +0800, Guo Zhengkui a écrit :
> Fix the following coccicheck warning:
> 
> drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c:
> 694:15-16: WARNING opportunity for min().
> 
> Signed-off-by: Guo Zhengkui <guozhengkui@xxxxxxxx>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@xxxxxxxxxxxxx>

> ---
>  .../media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c   | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> index f464af190d8c..81de876d5126 100644
> --- a/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> +++ b/drivers/media/platform/mediatek/vcodec/vdec/vdec_vp9_req_lat_if.c
> @@ -691,7 +691,7 @@ static int vdec_vp9_slice_tile_offset(int idx, int mi_num, int tile_log2)
>  	int sbs = (mi_num + 7) >> 3;
>  	int offset = ((idx * sbs) >> tile_log2) << 3;
>  
> -	return offset < mi_num ? offset : mi_num;
> +	return min(offset, mi_num);
>  }
>  
>  static

regards,
Nicolas