Re: [PATCH 3/3] arm64: dts: renesas: spider-cpu: Enable SCIF0 on second connector

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, Jun 13, 2022 at 3:49 PM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> The schematics label it as SCIF0 debug port.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Thanks for your patch!

> --- a/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779f0-spider-cpu.dtsi
> @@ -68,6 +68,11 @@ i2c4_pins: i2c4 {
>                 function = "i2c4";
>         };
>
> +       scif0_pins: scif0 {
> +               groups = "scif0_data", "scif0_ctrl";
> +               function = "scif0";
> +       };
> +
>         scif_clk_pins: scif_clk {
>                 groups = "scif_clk";
>                 function = "scif_clk";
> @@ -79,6 +84,14 @@ &rwdt {
>         status = "okay";
>  };
>
> +&scif0 {
> +       pinctrl-0 = <&scif0_pins>;
> +       pinctrl-names = "default";
> +
> +       uart-has-rtscts;
> +       status = "okay";
> +};
> +
>  &scif_clk {
>         clock-frequency = <24000000>;
>  };

This needs a new serial alias under /aliases.
Mixing dynamic and static serial IDs may cause conflicts, cfr. commit
7678f4c20fa7670f ("serial: sh-sci: Add support for dynamic instances").

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds