Re: [PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support

[Russell King (Oracle)]

On Tue, Jun 14, 2022 at 11:00:28AM +0800, Ong Boon Leong wrote:
> +int xpcs_modify_changed(struct dw_xpcs *xpcs, int dev, u32 reg,
> +			u16 mask, u16 set)

Why is this globally visible? I can find no reason for it in this patch
set.

> +{
> +	u32 reg_addr = mdiobus_c45_addr(dev, reg);
> +	struct mii_bus *bus = xpcs->mdiodev->bus;
> +	int addr = xpcs->mdiodev->addr;
> +
> +	return mdiobus_modify_changed(bus, addr, reg_addr, mask, set);

There is a mdiodev_modify_changed() which would be slightly cleaner
here.

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!