Re: [PATCH 5/7] tty/vt: consolemap: rename struct vc_data::vc_uni_pagedir*

From: Ilpo Järvinen
Date: Tue Jun 14 2022 - 04:40:45 EST


On Tue, 14 Jun 2022, Jiri Slaby wrote:

> As a follow-up to the commit 4173f018aae1 (tty/vt: consolemap: rename
> and document struct uni_pagedir), rename also the members of struct
> vc_data. I.e. pagedir -> pagedict. And while touching all the places,
> remove also the unnecessary vc_ prefix.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>

Look fine,

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>


You might want to rename vgacon_uni_pagedir too. :-)


--
i.