Re: [PATCH] spi: microchip-core: fix potentially incorrect return from probe

[Conor.Dooley]

On 14/06/2022 07:58, Conor Dooley wrote:
> If platform_get_irqi() returns 0, the error case will be triggered but
> probe() will return 0 rather than an error. Ape the other drivers using
> this pattern and return -ENXIO.
> 
> Reported-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>
> Link: https://lore.kernel.org/linux-spi/20220609055533.95866-2-yang.lee@xxxxxxxxxxxxxxxxx/

Woops, forgot this one:
Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")

> Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> ---
>   drivers/spi/spi-microchip-core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
> index 5b22a1395554..856a68fd8e9f 100644
> --- a/drivers/spi/spi-microchip-core.c
> +++ b/drivers/spi/spi-microchip-core.c
> @@ -541,7 +541,7 @@ static int mchp_corespi_probe(struct platform_device *pdev)
>   	spi->irq = platform_get_irq(pdev, 0);
>   	if (spi->irq <= 0) {
>   		dev_err(&pdev->dev, "invalid IRQ %d for SPI controller\n", spi->irq);
> -		ret = spi->irq;
> +		ret = -ENXIO;
>   		goto error_release_master;
>   	}
>