Re: [PATCH v5 4/6] kernel/watchdog: Adapt the watchdog_hld interface for async model

From: kernel test robot
Date: Tue Jun 14 2022 - 02:19:27 EST


Hi Lecopzer,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on arm/for-next kvmarm/next soc/for-next]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/Lecopzer-Chen/Support-hld-delayed-init-based-on-Pseudo-NMI-for/20220614-021318
base: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: hexagon-randconfig-r024-20220613 (https://download.01.org/0day-ci/archive/20220614/202206141412.PeVDy6qk-lkp@xxxxxxxxx/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d378268ead93c85803c270277f0243737b536ae7)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/7df94eb967160312b005f9d8a29b558beec2d5a7
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Lecopzer-Chen/Support-hld-delayed-init-based-on-Pseudo-NMI-for/20220614-021318
git checkout 7df94eb967160312b005f9d8a29b558beec2d5a7
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> kernel/watchdog.c:915:3: error: use of undeclared identifier 'allow_lockup_detector_init_retry'
allow_lockup_detector_init_retry = true;
^
1 error generated.


vim +/allow_lockup_detector_init_retry +915 kernel/watchdog.c

903
904 void __init lockup_detector_init(void)
905 {
906 if (tick_nohz_full_enabled())
907 pr_info("Disabling watchdog on nohz_full cores by default\n");
908
909 cpumask_copy(&watchdog_cpumask,
910 housekeeping_cpumask(HK_TYPE_TIMER));
911
912 if (!watchdog_nmi_probe())
913 nmi_watchdog_available = true;
914 else
> 915 allow_lockup_detector_init_retry = true;

--
0-DAY CI Kernel Test Service
https://01.org/lkp