Re: [PATCH v1 1/1] phy: ti: tusb1210: Don't check for write errors when powering on

[Ferry Toth]

Op 13-06-2022 om 22:40 schreef Ferry Toth:
> Hi
>
> Op 13-06-2022 om 18:08 schreef Andy Shevchenko:
> > On some platforms, like Intel Merrifield, the writing values during 
> > power on
> > may timeout:
> >
> >     tusb1210 dwc3.0.auto.ulpi: error -110 writing val 0x41 to reg 0x80
> with the patch this error continues to appear in the logs
> >     phy phy-dwc3.0.auto.ulpi.0: phy poweron failed --> -110
> >     dwc3 dwc3.0.auto: error -ETIMEDOUT: failed to initialize core
> >     dwc3: probe of dwc3.0.auto failed with error -110
> these errors are gone
> > which effectively fails the probe of the USB controller.
>
> and probe of dwc3 succeeds
>
> Tested on Intel Edison (Merrifield)

Tested-by: Ferry Toth <fntoth@xxxxxxxxx>

> > Drop the check as it was before the culprit commit (see Fixes tag).
> >
> > Fixes: 09a3512681b3 ("phy: ti: tusb1210: Improve ulpi_read()/_write() 
> > error checking")
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> >   drivers/phy/ti/phy-tusb1210.c | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/phy/ti/phy-tusb1210.c 
> > b/drivers/phy/ti/phy-tusb1210.c
> > index c3ab4b69ea68..669c13d6e402 100644
> > --- a/drivers/phy/ti/phy-tusb1210.c
> > +++ b/drivers/phy/ti/phy-tusb1210.c
> > @@ -105,8 +105,9 @@ static int tusb1210_power_on(struct phy *phy)
> >       msleep(TUSB1210_RESET_TIME_MS);
> >       /* Restore the optional eye diagram optimization value */
> > -    return tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2,
> > -                   tusb->vendor_specific2);
> > +    tusb1210_ulpi_write(tusb, TUSB1210_VENDOR_SPECIFIC2, 
> > tusb->vendor_specific2);
> > +
> > +    return 0;
> >   }
> >   static int tusb1210_power_off(struct phy *phy)