Re: [PATCH v4 18/18] PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration

From: Rob Herring
Date: Mon Jun 13 2022 - 17:09:40 EST


On Fri, Jun 10, 2022 at 11:25:34AM +0300, Serge Semin wrote:
> The denoted forward declaration used to be required to get the OF-device
> ID structure by calling the of_match_device() method. The later method
> invocation has been replaced with the of_device_get_match_data() call in
> the commit 5c204204cf24 ("PCI: designware-plat: Prefer
> of_device_get_match_data()"). Thus the forward declaration of the
> OF-compatible device strings no longer needed. Drop it for good.
>
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> Tested-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
> drivers/pci/controller/dwc/pcie-designware-plat.c | 2 --
> 1 file changed, 2 deletions(-)

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>