Re: [PATCH] spi: spidev_test: Warn when the mode is not the requested mode

From: Mark Brown
Date: Mon Jun 13 2022 - 11:03:12 EST


On Mon, Jun 13, 2022 at 12:39:41AM -0500, David Fries wrote:

> + /* Drivers can reject some mode bits without returning an error.
> + * Read the current value to identify what mode it is in, and if it
> + * differs from the requested mode, warn the user.
> + */
> + if(request != mode)

Please try to follow the kernel coding style - both the if( and the
comment don't.

Attachment: signature.asc
Description: PGP signature