Re: [PATCH v2] pinctrl: nuvoton: wpcm450: Convert irqchip to IRQCHIP_IMMUTABLE

[Jonathan Neuschäfer]

On Fri, Jun 10, 2022 at 02:07:55PM +0200, Andy Shevchenko wrote:
> On Fri, Jun 10, 2022 at 2:24 AM Jonathan Neuschäfer
> <j.neuschaefer@xxxxxxx> wrote:
> >
> > Commit 6c846d026d490 ("gpio: Don't fiddle with irqchips marked as
> > immutable") added a warning for irqchips that are not marked with
> > IRQCHIP_IMMUTABLE.
> >
> > Convert the pinctrl-wpcm450 driver to an immutable irqchip.
> 
> ...
> 
> > +       gpiochip_disable_irq(gc, d->hwirq);
> 
> > +       gpiochip_enable_irq(gc, d->hwirq);
> 
> Can you use the helper (*) as stated in the documentation?
> 
> *) irqd_to_hwirq(d)

Ah, oops. I'll fix it.


Thanks,
Jonathan

Attachment: signature.asc
Description: PGP signature