Re: mainline build failure due to 6c77676645ad ("iov_iter: Fix iter_xarray_get_pages{,_alloc}()")
From: David Howells
Date: Mon Jun 13 2022 - 05:19:34 EST
Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> The reason we can't overflow on multiplication there, BTW, is that we have
> nr <= count, and count has come from weirdly open-coded
> DIV_ROUND_UP(size + offset, PAGE_SIZE)
> IMO we'd better make it explicit, so how about the following:
>
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
It seems reasonable.
Reviewed-by: David Howells <dhowells@xxxxxxxxxx>