Re: [PATCH 2/2] serial: 8250_pericom: Use UART_LCR_DLAB

[Jiri Slaby]

On 13. 06. 22, 9:57, Ilpo Järvinen wrote:
> Use UART_LCR_DLAB instead of literal.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>

Reviewed-by: Jiri Slaby <jirislaby@xxxxxxxxxx>

> ---
>   drivers/tty/serial/8250/8250_pericom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pericom.c b/drivers/tty/serial/8250/8250_pericom.c
> index 95ff10f25d58..b8d5b7714a9d 100644
> --- a/drivers/tty/serial/8250/8250_pericom.c
> +++ b/drivers/tty/serial/8250/8250_pericom.c
> @@ -73,7 +73,7 @@ static void pericom_do_set_divisor(struct uart_port *port, unsigned int baud,
>   			struct uart_8250_port *up = up_to_u8250p(port);
>   			int lcr = serial_port_in(port, UART_LCR);
>   
> -			serial_port_out(port, UART_LCR, lcr | 0x80);
> +			serial_port_out(port, UART_LCR, lcr | UART_LCR_DLAB);
>   			serial_dl_write(up, divisor);
>   			serial_port_out(port, 2, 16 - scr);
>   			serial_port_out(port, UART_LCR, lcr);


--
js
suse labs