Re: [PATCH] rcu-tasks: Remove unused trc_wait and holdouts

From: Paul E. McKenney
Date: Fri Jun 10 2022 - 14:36:29 EST


On Fri, Jun 10, 2022 at 02:22:28PM +0800, Zqiang wrote:
> Remove unused trc_wait waitqueue and local holdouts list.
>
> Signed-off-by: Zqiang <qiang1.zhang@xxxxxxxxx>

Good eyes, thank you! I will fold this into the original commit
with attribution.

Thanx, Paul

> ---
> kernel/rcu/tasks.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index 55e76db8b0d3..fcbd0ec33c86 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -1190,8 +1190,6 @@ EXPORT_SYMBOL_GPL(rcu_trace_lock_map);
>
> #ifdef CONFIG_TASKS_TRACE_RCU
>
> -static DECLARE_WAIT_QUEUE_HEAD(trc_wait); // List of holdout tasks.
> -
> // Record outstanding IPIs to each CPU. No point in sending two...
> static DEFINE_PER_CPU(bool, trc_ipi_to_cpu);
>
> @@ -1641,7 +1639,6 @@ static void rcu_tasks_trace_empty_fn(void *unused)
> static void rcu_tasks_trace_postgp(struct rcu_tasks *rtp)
> {
> int cpu;
> - LIST_HEAD(holdouts);
>
> // Wait for any lingering IPI handlers to complete. Note that
> // if a CPU has gone offline or transitioned to userspace in the
> --
> 2.25.1
>