Re: [PATCH] ASoC: samsung: i2s: Check before clk_unregister() not needed

[Christophe JAILLET]

Le 29/05/2022 à 10:06, Krzysztof Kozlowski a écrit :
> On 27/05/2022 08:54, Yihao Han wrote:
> > clk_unregister() already checks the clk ptr using
> > !clk || WARN_ON_ONCE(IS_ERR(clk)) so there is no need to check it
> > again before calling it.
>
> No, this explanation does not make sense. clk_unregister() warns and
> this code is not equivalent.
>
>
>
> Best regards,
> Krzysztof

Hi,

Moreover, as pointed out by greg in [1] on some plateform the assertion 
in the commit description is wrong. His message is about clk_disable() 
but, IIUC, it makes sense for clk_unregister() as well. See [2] on the 
sh plateform.

CJ

[1]: https://lore.kernel.org/all/YqMIUOTU%2Fk5XpW3I@xxxxxxxxx/
[2]: 
https://elixir.bootlin.com/linux/v5.18.3/source/drivers/sh/clk/core.c#L452