RE: [PATCH v3 6/6] ufs: host: ufs-exynos: add support for fsd ufs hci

[Alim Akhtar]

>-----Original Message-----
>From: Chanho Park [mailto:chanho61.park@xxxxxxxxxxx]
>Sent: Friday, June 10, 2022 2:06 PM
>To: 'Alim Akhtar' <alim.akhtar@xxxxxxxxxxx>; linux-arm-
>kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
>scsi@xxxxxxxxxxxxxxx; linux-phy@xxxxxxxxxxxxxxxxxxx
>Cc: devicetree@xxxxxxxxxxxxxxx; robh+dt@xxxxxxxxxx;
>krzysztof.kozlowski+dt@xxxxxxxxxx; vkoul@xxxxxxxxxx; avri.altman@xxxxxxx;
>bvanassche@xxxxxxx; martin.petersen@xxxxxxxxxx;
>pankaj.dubey@xxxxxxxxxxx; 'Bharat Uppal' <bharat.uppal@xxxxxxxxxxx>
>Subject: RE: [PATCH v3 6/6] ufs: host: ufs-exynos: add support for fsd ufs hci
>
>> Subject: [PATCH v3 6/6] ufs: host: ufs-exynos: add support for fsd ufs
>> hci
>>
>> Adds support of UFS HCI which is found in Tesla Full Self-Driving
>> (FSD) SoC.
>>
>> Signed-off-by: Bharat Uppal <bharat.uppal@xxxxxxxxxxx>
>> Signed-off-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
>> ---
>>  drivers/ufs/host/ufs-exynos.c | 140
>++++++++++++++++++++++++++++++++++
>>  drivers/ufs/host/ufs-exynos.h |   1 +
>>  2 files changed, 141 insertions(+)
>>
>> diff --git a/drivers/ufs/host/ufs-exynos.c
>> b/drivers/ufs/host/ufs-exynos.c index cc128aff8871..19068605d9fe
>> 100644
>> --- a/drivers/ufs/host/ufs-exynos.c
>> +++ b/drivers/ufs/host/ufs-exynos.c
>> @@ -146,6 +146,10 @@ enum {
>>  #define UNIPRO_DME_PWR_REQ_REMOTEL2TIMER1	0x0A8
>>  #define UNIPRO_DME_PWR_REQ_REMOTEL2TIMER2	0x0AC
>>
>> +#define DME_POWERMODE_REQ_REMOTEL2TIMER0	0x78B8
>> +#define DME_POWERMODE_REQ_REMOTEL2TIMER1	0x78BC
>> +#define DME_POWERMODE_REQ_REMOTEL2TIMER2	0x78C0
>
>They look mismatch naming with previous definitions.
>UNIPRO_DME_POWERMODE_*
>
Ok noted.
Also previous definitions are not used, so I will send a separate patch to clean them up.

>Best Regards,
>Chanho Park