Re: [PATCH 1/2] blk-iocost: remove the second superfluous current_hweight

From: Andreas Herrmann
Date: Fri Jun 10 2022 - 04:46:12 EST


On Thu, Jun 09, 2022 at 03:34:49PM +0800, Chengming Zhou wrote:
> The commit ac33e91e2dac ("blk-iocost: implement vtime loss compensation")
> add the second current_hweight() in the loop of active iocgs list to
> get old_hwi to calculate the vtime loss of the iocg.
>
> Since the hwi can't change and the first current_hweight already get
> hwa and hwi, so this second superfluous current_hweight() can be
> removed. There should be no functional changes.
>
> Signed-off-by: Chengming Zhou <zhouchengming@xxxxxxxxxxxxx>

FWIW. Looks ok.
Reviewed-by: Andreas Herrmann <aherrmann@xxxxxxx>