Re: [PATCH 04/12] blk-cgroup: use correct format characters

From: Christoph Hellwig
Date: Fri Jun 10 2022 - 04:11:15 EST


On Thu, Jun 09, 2022 at 10:16:23PM +0000, Bill Wendling wrote:
> vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args);
> - dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name);
> + dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, "%s", bdi->dev_name);

Please avoid the overly long line. But given that bdi names aren't user
input this warning seems to shoot from the hip a bit.