Re: [v10 1/1] thermal: mediatek: add another get_temp ops for thermal sensors

From: James Lo
Date: Fri Jun 10 2022 - 01:59:04 EST


On Thu, 2022-05-19 at 13:12 +0200, AngeloGioacchino Del Regno wrote:
> Il 19/05/22 12:10, James Lo ha scritto:
> > Provide thermal zone to read thermal sensor
> > in the SoC. We can read all the thermal sensors
> > value in the SoC by the node /sys/class/thermal/
> >
> > In mtk_thermal_bank_temperature, return -EAGAIN instead of -EACCESS
> > on the first read of sensor that often are bogus values.
> > This can avoid following warning on boot:
> >
> > thermal thermal_zone6: failed to read out thermal zone (-13)
> >
> > Signed-off-by: Michael Kao <michael.kao@xxxxxxxxxxxx>
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
> > Signed-off-by: Ben Tseng <ben.tseng@xxxxxxxxxxxx>
> > Signed-off-by: James Lo <james.lo@xxxxxxxxxxxx>
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
>

Hello Rafael, Daniel and Matthias,

Can you give us some suggestions for this patch?
Thanks!

BRs,
James