Re: [PATCH net-next v1 1/5] ptp_ocp: use dev_err_probe()

From: Jakub Kicinski
Date: Fri Jun 10 2022 - 01:45:35 EST


On Wed, 8 Jun 2022 15:03:54 +0300 Andy Shevchenko wrote:
> Simplify the error path in ->probe() and unify message format a bit
> by using dev_err_probe().

Let's not do this. I get that using dev_err_probe() even without
possibility of -EPROBE_DEFER is acceptable, but converting
existing drivers is too much IMO. Acceptable < best practice.