Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus

From: Randy Dunlap
Date: Thu Jun 09 2022 - 23:19:53 EST


Hi--

On 6/9/22 18:32, 郭力豪 wrote:
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 0e5cc94..c85e668 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL
> If you say yes here you get support for the FAN controlled
> by the Microcontroller found on the Khadas VIM boards.
>
> +config SUNPLUS_THERMAL
> + tristate "Sunplus thermal drivers"
> + depends on SOC_SP7021 || COMPILE_TEST
> + help
> + This enable the Sunplus SP7021 thermal driver, which supports the primitive
> + temperature sensor embedded in Sunplus SP7021 SoC.
> +
> + If you have a Sunplus SP7021 platform say Y here and enable this option
> + to have support for thermal management

End the sentence above with a period ('.').

And the indentation here is all messed up.
See Documentation/process/coding-style.rst:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different. Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


> +
> endif

--
~Randy