Re: [PATCH 1/1] MIPS: Loongson-3: fix compile mips cpu_hwmon as module build error.

From: Thomas Bogendoerfer
Date: Thu Jun 09 2022 - 16:27:01 EST


On Wed, Jun 08, 2022 at 09:12:29AM +0800, Yupeng Li wrote:
> set cpu_hwmon as a module build with loongson_sysconf, loongson_chiptemp
> undefined error,fix cpu_hwmon compile options to be bool.Some kernel
> compilation error information is as follows:
>
> Checking missing-syscalls for N32
> CALL scripts/checksyscalls.sh
> Checking missing-syscalls for O32
> CALL scripts/checksyscalls.sh
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> CC [M] drivers/platform/mips/cpu_hwmon.o
> Building modules, stage 2.
> MODPOST 200 modules
> ERROR: "loongson_sysconf" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> ERROR: "loongson_chiptemp" [drivers/platform/mips/cpu_hwmon.ko] undefined!
> make[1]: *** [scripts/Makefile.modpost:92:__modpost] 错误 1
> make: *** [Makefile:1261:modules] 错误 2
>
> Signed-off-by: Yupeng Li <liyupeng@xxxxxxxxxx>
> ---
> drivers/platform/mips/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/mips/Kconfig b/drivers/platform/mips/Kconfig
> index d421e1482395..6b51ad01f791 100644
> --- a/drivers/platform/mips/Kconfig
> +++ b/drivers/platform/mips/Kconfig
> @@ -17,7 +17,7 @@ menuconfig MIPS_PLATFORM_DEVICES
> if MIPS_PLATFORM_DEVICES
>
> config CPU_HWMON
> - tristate "Loongson-3 CPU HWMon Driver"
> + bool "Loongson-3 CPU HWMon Driver"
> depends on MACH_LOONGSON64
> select HWMON
> default y
> --
> 2.34.1

applied to mips-fixes.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]