Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab

[Masahiro Yamada]

On Fri, Jun 10, 2022 at 2:17 AM Mickaël Salaün <mic@xxxxxxxxxxx> wrote:
>
>
>
> On 09/06/2022 19:12, Mickaël Salaün wrote:
> >
> > On 06/06/2022 18:49, Masahiro Yamada wrote:
> >> On Mon, Jun 6, 2022 at 9:32 PM David Howells <dhowells@xxxxxxxxxx> wrote:
> >>>
> >>> There's a rule in certs/Makefile for which the command begins with eight
> >>> spaces.  This results in:
> >>>
> >>>          ../certs/Makefile:21: FORCE prerequisite is missing
> >>>          ../certs/Makefile:21: *** missing separator.  Stop.
> >>>
> >>> Fix this by turning the spaces into a tab.
> >>>
> >>> Fixes: addf466389d9 ("certs: Check that builtin blacklist hashes are
> >>> valid")
> >>> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>
> >>> cc: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx>
> >>> cc: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> >>> cc: keyrings@xxxxxxxxxxxxxxx
> >>
> >>
> >> Not only 8-space indentation, but also:
> >>
> >>    - config_filename does not exist
> >>    - $(SYSTEM_BLACKLIST_HASH_LIST_SRCPREFIX) is always empty
> >>    - $(SYSTEM_BLACKLIST_HASH_LIST_FILENAME) is always empty
> >
> > These are imported helpers (not only used for this hash list BTW), hence
> > not defined in this Makefile.
>
> Well, they were defined in scripts/Kbuild.include but they are gone
> since your commit b8c96a6b466c ("certs: simplify $(srctree)/ handling
> and remove config_filename macro").
>
> I guess it just happens during the merge. We need to fix that.
>




Right, it seems your patch was flying for a long time.





$ git show --pretty=fuller   addf466389d9d78f255e8b15ac44ab4791029852
commit addf466389d9d78f255e8b15ac44ab4791029852
Author:     Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx>
AuthorDate: Mon Jul 12 19:03:10 2021 +0200
Commit:     Jarkko Sakkinen <jarkko@xxxxxxxxxx>
CommitDate: Mon May 23 18:47:49 2022 +0300

    certs: Check that builtin blacklist hashes are valid




It was committed 8 months after the patch submission.

The base code changed during the gap.




--
Best Regards
Masahiro Yamada