Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab

From: Masahiro Yamada
Date: Thu Jun 09 2022 - 14:19:58 EST


On Fri, Jun 10, 2022 at 2:05 AM Mickaël Salaün <mic@xxxxxxxxxxx> wrote:
>
>
> On 06/06/2022 14:31, David Howells wrote:
> > There's a rule in certs/Makefile for which the command begins with eight
> > spaces. This results in:
> >
> > ../certs/Makefile:21: FORCE prerequisite is missing
> > ../certs/Makefile:21: *** missing separator. Stop.
> >
> > Fix this by turning the spaces into a tab.
>
> These spaces were not part of my patch but they are indeed in this file
> now: https://lore.kernel.org/r/20210712170313.884724-3-mic@xxxxxxxxxxx
>
> Reviewed-by: Mickaël Salaün <mic@xxxxxxxxxxxxxxxxxxx>


Indeed, you used a tab,
but the applied code (commit addf466389d9) uses 8 spaces.

I think something bad happened
when the committer locally modified the code.






--
Best Regards
Masahiro Yamada