Re: [PATCH v2 10/10] rtw88: disable powersave modes for USB devices

From: Ping-Ke Shih
Date: Thu Jun 09 2022 - 08:52:32 EST


On Tue, 2022-05-31 at 09:42 +0200, s.hauer@xxxxxxxxxxxxxx wrote:
> On Tue, May 31, 2022 at 01:07:36AM +0000, Ping-Ke Shih wrote:
> > On Mon, 2022-05-30 at 15:54 +0200, Sascha Hauer wrote:
> > > The powersave modes do not work with USB devices (tested with a
> > > RTW8822CU) properly. With powersave modes enabled the driver issues
> > > messages like:
> > >
> > > rtw_8822cu 1-1:1.2: firmware failed to leave lps state
> > > rtw_8822cu 1-1:1.2: timed out to flush queue 3
> >
> > Could you try module parameter rtw_disable_lps_deep_mode=1 to see
> > if it can work?
>
> No, this module parameter doesn't seem to make any difference.
>
> # cat /sys/module/rtw88_core/parameters/disable_lps_deep
> Y
>
> Still "firmware failed to leave lps state" and poor performance.
>
> Any other ideas what may go wrong here?
>

Today, I borrow a 8822cu, and use your patchset but revert
patch 10/10 to reproduce this issue. With firmware 7.3.0,
it looks bad. After checking something about firmware, I
found the firmware is old, so upgrade to 9.9.11, and then
it works well for 10 minutes, no abnormal messages.

Please try if it also works to you.

Ping-Ke