Re: [PATCH 2/3] clk: qcom: gdsc: add support for collapse-vote registers

From: Johan Hovold
Date: Thu Jun 09 2022 - 07:50:46 EST


On Thu, May 26, 2022 at 11:32:17AM -0700, Stephen Boyd wrote:
> Quoting Johan Hovold (2022-05-23 05:04:44)
> > On Fri, May 20, 2022 at 08:52:26PM -0700, Stephen Boyd wrote:
> > > Quoting Johan Hovold (2022-05-20 03:09:47)
> > > > Recent Qualcomm platforms have APCS collapse-vote registers that allow
> > > > for sharing GDSCs with other masters (e.g. LPASS).
> > >
> > > Maybe just say 'with other subsystems' because LPASS is an entire
> > > subsystem.
> >
> > The term "subsystem" is too broad and also has a different meaning in
> > Linux.
> >
> > The vendor kernel uses "masters" here which is clear enough and
> > presumably matches their documentation.
> >
>
> How about "voter"? Then it isn't confused with linux subsystems.

Yeah, voters vote, but that's not very informative, is it?

I don't see any reason to obfuscate the commit message here.

Johan