Re: [PATCH] vfio: de-extern-ify function prototypes

From: Cornelia Huck
Date: Thu Jun 09 2022 - 04:10:28 EST


On Wed, Jun 08 2022, Alex Williamson <alex.williamson@xxxxxxxxxx> wrote:

> The use of 'extern' in function prototypes has been disrecommended in
> the kernel coding style for several years now, remove them from all vfio
> related files so contributors no longer need to decide between style and
> consistency.
>
> Signed-off-by: Alex Williamson <alex.williamson@xxxxxxxxxx>
> ---
>
> A patch in the same vein was proposed about a year ago, but tied to an ill
> fated series and forgotten. Now that we're at the beginning of a new
> development cycle, I'd like to propose kicking off the v5.20 vfio next
> branch with this patch and would kindly ask anyone with pending respins or
> significant conflicts to rebase on top of this patch. Thanks!
>
> Documentation/driver-api/vfio-mediated-device.rst | 10 ++-
> drivers/s390/cio/vfio_ccw_cp.h | 12 ++--
> drivers/s390/cio/vfio_ccw_private.h | 6 +-
> drivers/vfio/fsl-mc/vfio_fsl_mc_private.h | 2 -
> drivers/vfio/platform/vfio_platform_private.h | 21 +++---
> include/linux/vfio.h | 70 ++++++++++-----------
> include/linux/vfio_pci_core.h | 65 ++++++++++----------
> 7 files changed, 91 insertions(+), 95 deletions(-)

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>