Re: [PATCH v4 1/1] nvme: handle persistent internal error AER from NVMe controller

[Chaitanya Kulkarni]

On 6/8/2022 6:30 PM, Michael Kelley (LINUX) wrote:
> From: Chaitanya Kulkarni <chaitanyak@xxxxxxxxxx>
>>
>> On 6/8/22 17:22, Chaitanya Kulkarni wrote:
>>> On 6/8/22 11:52, Michael Kelley wrote:
>>>> In the NVM Express Revision 1.4 spec, Figure 145 describes possible
>>>> values for an AER with event type "Error" (value 000b). For a
>>>> Persistent Internal Error (value 03h), the host should perform a
>>>> controller reset.
>>>>
>>>> Add support for this error using code that already exists for
>>>> doing a controller reset. As part of this support, introduce
>>>> two utility functions for parsing the AER type and subtype.
>>>>
>>>> This new support was tested in a lab environment where we can
>>>> generate the persistent internal error on demand, and observe
>>>> both the Linux side and NVMe controller side to see that the
>>>> controller reset has been done.
>>>>
>>>>
>>
>> Can you please clarify that which transports you have tested
>> such as RDMA, TCP, and PCIe ?
>>
> 
> I've tested PCIe only -- that's all I have access to.  I can tweak
> the commit message to be more specific.
> 
> Michael

It's okay we have it documented now, thanks again.

-ck