Re: [net-next v2 1/2] bonding: netlink error message support for options

From: Jay Vosburgh
Date: Wed Jun 08 2022 - 14:53:09 EST


Jonathan Toppins <jtoppins@xxxxxxxxxx> wrote:

>Add support for reporting errors via extack in both bond_newlink
>and bond_changelink.
>
>Instead of having to look in the kernel log for why an option was not
>correct just report the error to the user via the extack variable.
>
>What is currently reported today:
> ip link add bond0 type bond
> ip link set bond0 up
> ip link set bond0 type bond mode 4
> RTNETLINK answers: Device or resource busy
>
>After this change:
> ip link add bond0 type bond
> ip link set bond0 up
> ip link set bond0 type bond mode 4
> Error: unable to set option because the bond is up.
>
>Signed-off-by: Jonathan Toppins <jtoppins@xxxxxxxxxx>

Acked-by: Jay Vosburgh <jay.vosburgh@xxxxxxxxxxxxx>