Re: [PATCH v4 3/4] fat: add renameat2 RENAME_EXCHANGE flag support

From: Javier Martinez Canillas
Date: Wed Jun 08 2022 - 14:21:55 EST


On 6/8/22 19:10, OGAWA Hirofumi wrote:
> Javier Martinez Canillas <javierm@xxxxxxxxxx> writes:
>

[snip]

>>> Probably, we should change the nlink only if both of dotdot update are
>>> succeed and different file type. Otherwise, we would have to revert the
>>> nlink change on error path (and can remove unnecessary update as bonus).
>>>
>>
>> Agreed. I'll wait a few days before posting v5 in case you have more
>> comments on the other patches.
>
> Ok. I have no comment other than this at least for now (reviewed all
> patches). If I found more on re-review I will send email.
>

Perfect, thanks! If you reviewed all the patches already then I'll send
the v6 tomorrow.

--
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat