Re: [PATCH 1/5] ext2: remove nobh support

From: Matthew Wilcox
Date: Wed Jun 08 2022 - 12:40:08 EST


On Wed, Jun 08, 2022 at 05:04:47PM +0200, Christoph Hellwig wrote:
> @@ -551,7 +548,8 @@ static int parse_options(char *options, struct super_block *sb,
> clear_opt (opts->s_mount_opt, OLDALLOC);
> break;
> case Opt_nobh:
> - set_opt (opts->s_mount_opt, NOBH);
> + ext2_msg(sb, KERN_INFO,
> + "nobh option not supported");
> break;

This is the only part I wonder about. Should we just silently accept
the nobh option instead of emitting a message?

Also, is it time to start emitting a message for nfs' intr option? ;-)