Re: [PATCH 1/2] HID: intel-ish-hid: ipc: use time_before to replace "jiffies < a"

From: Jiri Kosina
Date: Wed Jun 08 2022 - 07:06:25 EST


On Mon, 6 Jun 2022, Li Qiong wrote:

> time_before deals with timer wrapping correctly.
>
> Signed-off-by: Li Qiong <liqiong@xxxxxxxxxxxx>
> ---
> drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 8ccb246b0114..15e14239af82 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -578,7 +578,7 @@ static void _ish_sync_fw_clock(struct ishtp_device *dev)
> static unsigned long prev_sync;
> uint64_t usec;
>
> - if (prev_sync && jiffies - prev_sync < 20 * HZ)
> + if (prev_sync && time_before(jiffies, prev_sync + 20 * HZ))
> return;

Applied, thanks.

--
Jiri Kosina
SUSE Labs