Re: [PATCH] random: remove rng_has_arch_random()

From: Petr Mladek
Date: Wed Jun 08 2022 - 06:05:25 EST


On Wed 2022-06-08 10:34:59, Jason A. Donenfeld wrote:
> With arch randomness being used by every distro and enabled in
> defconfigs, the distinction between rng_has_arch_random() and
> rng_is_initialized() is now rather small. In fact, the places where they
> differ are now places where paranoid users and system builders really
> don't want arch randomness to be used, in which case we should respect
> that choice, or places where arch randomness is known to be broken, in
> which case that choice is all the more important. So this commit just
> removes the function and its one user.
>
> Cc: Petr Mladek <pmladek@xxxxxxxx>
> Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>

I am not expert on random numbers but it sounds reasonable.
Anyway, the change in vsprintf.c looks good:

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> # vsprintf.c

Best Regards,
Petr