Re: [PATCH v2 15/15] platform/chrome: cros_ec_proto: return 0 on getting wake mask success

From: Tzung-Bi Shih
Date: Wed Jun 08 2022 - 01:13:51 EST


On Tue, Jun 07, 2022 at 12:12:25PM -0700, Guenter Roeck wrote:
> On Tue, Jun 7, 2022 at 7:57 AM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
> >
> > cros_ec_get_host_event_wake_mask() used to return value from
> > send_command() which is number of bytes for input payload on success
> > (i.e. sizeof(struct ec_response_host_event_mask)).
> >
> > However, the callers don't need to know how many bytes are available.
> >
> > - Fix cros_ec_get_host_event_wake_mask() to return 0 on success;
> > negative integers on error.
> >
> > - Add a Kunit test for guarding if send_command() returns 0 in
> > get_host_event_wake_mask().
> >
> Please split into two patches.

Ack.