Re: [PATCH crypto v2] crypto: blake2s - remove shash module
From: Jason A. Donenfeld
Date: Sat May 28 2022 - 05:57:17 EST
Hi Eric,
On Fri, May 27, 2022 at 08:59:29PM -0700, Eric Biggers wrote:
> On Fri, May 27, 2022 at 10:11:06AM +0200, Jason A. Donenfeld wrote:
> > BLAKE2s has no use as an shash, with no users of it.
>
> "no use" => "no known current use".
Ack.
> This doesn't compile on arm, since blake2s_compress_generic() isn't defined.
Grr, thanks. I'll fix that and verify before sending v3.
> Also, the wrong value is being passed for the 'inc' argument.
Are you sure? Not sure I'm seeing what you are on first glance.
> 2048 iterations is also a lot. Doing a lot of iterations here doesn't
> meaningfully increase the test coverage.
For symmetric things like this, yeah, you're right. I'll reduce that to
a more modest 100 or something.
> And please run checkpatch; those are some very long lines :-(
Ack.
Jason