On Tue, May 24, 2022 at 07:40:51AM +0530, Sibi Sankar wrote:
Hey Rob,
Thanks for taking time to review the series.
On 5/21/22 4:10 AM, Rob Herring wrote:
On Thu, May 19, 2022 at 10:17:05PM +0530, Sibi Sankar wrote:
Convert SC7180 MSS PIL loading bindings to YAML.
I suppose there is a reason the sc7180 is being split out and the only
one converted, but this doesn't tell me.
https://lore.kernel.org/all/e3543961-1645-b02a-c869-f8fa1ad2d41c@xxxxxxxxxxx/#t
The reason for the split was discussed on the list ^^, thought it
wouldn't make much sense adding any of it to the commit message.
Why not? If you did, then we wouldn't be having this conversation.
Commit messages, at a minimum, should answer why are you making the
change. They don't really need to explain what the change is. We can all
read the diff to understand that.
Rob