On 13/05/2022 08:48, Jacky Huang wrote:
No, it is not a generic node name. Please read my reply again.OK, I will modify it as+No underscores in node name. Generic node names, so "clock-X" or
+ hxt_24m: hxt_24mhz {
"clock-some-suffix"
hxt-24m: hxt-24mhz
This does not explain why you need simple-mfd. simple-mfd is not forIt's an external crystal on the board.+ compatible = "fixed-clock";This does not look like property of SoC. Where is this clock defined? In
+ #clock-cells = <0>;
+ clock-frequency = <24000000>;
the SoC or on the board?
I add this node, because it's the clock source of clock controller.
It always present on all ma35d1 boards.
clk: clock-controller@40460200 {
compatible = "nuvoton,ma35d1-clk";
reg = <0x0 0x40460200 0x0 0x100>;
#clock-cells = <1>;
clocks = <&hxt_24m>;
clock-names = "HXT_24MHz";
...
It's not a device, but a set of registers for system level control.+ clock-output-names = "HXT_24MHz";Why is this a simple-mfd if there are no children here? What do you want
+ };
+
+ timer {
+ compatible = "arm,armv8-timer";
+ interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>,
+ <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) |
+ IRQ_TYPE_LEVEL_LOW)>;
+ clock-frequency = <12000000>;
+ };
+
+ sys: system-controller@40460000 {
+ compatible = "nuvoton,ma35d1-sys", "syscon", "simple-mfd";
to instantiate here?
I want to provide a register base mapping for other devices to access
system control registers.
providing a register base mapping for other devices.
All of these should fail on checkpatch which points that you either didWhere is the nuvoton,ma35d1-sys compatible documented?OK, I will add the compatible document in next version.
I will also add the document for it.+ reg = <0x0 0x40460000 0x0 0x400>;Also not documented.
+ };
+
+ reset: reset-controller {
+ compatible = "nuvoton,ma35d1-reset";
not run it or ignored the result.
Please run checkpatch on all your submissions to Linux kernel and be
sure that there is no warning or error.
Best regards,
Krzysztof