On 5/12/2022 2:13 AM, Ian Rogers wrote:
Keep topdown events within a group when a weak group is broken. This
is a requirement as topdown events must form a group.
Add perf stat testing including for required topdown event group
behaviors.
Note: as with existing topdown evsel/evlist code topdown events are
assumed to be on the PMU "cpu". On Alderlake the PMU "cpu_core" should
also be tested. Future changes can fix Alderlake.
I will send a follow-up patch to fix the weak grouping for the hybrid platform shortly.
For the non-hybrid platform, the patch set looks good to me.
Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
Thanks,
Kan
v2. Correct behavior wrt pmu prefixed events and avoid the test using
deprecated events: Suggested-by: Liang, Kan <kan.liang@xxxxxxxxxxxxxxx>
Ian Rogers (2):
perf evlist: Keep topdown counters in weak group
perf test: Add basic stat and topdown group test
tools/perf/arch/x86/util/evsel.c | 12 ++++++
tools/perf/tests/shell/stat.sh | 67 ++++++++++++++++++++++++++++++++
tools/perf/util/evlist.c | 16 +++++++-
tools/perf/util/evsel.c | 10 +++++
tools/perf/util/evsel.h | 3 ++
5 files changed, 106 insertions(+), 2 deletions(-)
create mode 100755 tools/perf/tests/shell/stat.sh