Re: [PATCH v2] MIPS: undefine and redefine cpu_has_fpu when it is overrided

From: Stephen Zhang
Date: Sat Apr 30 2022 - 22:55:23 EST


Maciej W. Rozycki <macro@xxxxxxxxxxx> 于2022年4月30日周六 23:38写道:
>
> Adding a safety check would be a separate improvement. Please feel free
> to submit one.
>
> We need to keep fixes and improvements as separate changes. For one
> fixes can be candidates for backporting while improvements are never
> backported; cf. Documentation/process/stable-kernel-rules.rst.
>
> I hope this clears your concerns. Let me know if you have further
> questions.
>
> Maciej

Thanks for your elaboration.It helps a lot.
I want to submit a v3 patch like:

#if cpu_has_fpu
# error "Forcing `cpu_has_fpu' to non-zero is not supported"
#endif

but this will cause the link error if not combined with the fix:

MIPS: IP30: Remove incorrect `cpu_has_fpu' override

Maybe I should submit one first, and see how it goes then.