Re: [PATCH v3] uio: dfl: add HSSI subsystem feature id

[Xu Yilun]

On Fri, Apr 29, 2022 at 05:23:53AM -0700, Tom Rix wrote:
> 
> On 4/28/22 5:57 PM, Tianfei Zhang wrote:
> > From: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> > 
> > Add the Device Feature List (DFL) feature id for the
> > High Speed Serial Interface (HSSI) Subsystem to the
> > table of ids supported by the uio_dfl driver.
> > 
> > The HSSI Subsystem is a configurable set of IP blocks
> > to be used as part of a Ethernet or PCS/FEC/PMA pipeline.
> > Like the Ethernet group used by the N3000 card, the HSSI
> > Subsystem does not fully implement a network device from
> > a Linux netdev perspective and is controlled and monitored
> > from user space software via the uio interface.
> 
> Generally you should include the url for the dfl definitions.
> 
> Can you add it here to the commit log ?

Do you refer to this url, https://github.com/OPAE/dfl-feature-id ?

Hao has some comments about this at

  https://lore.kernel.org/all/DM6PR11MB38190E6EEF6DE3EB900290C585F39@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/

> 
> Otherwise fine.
> 
> Reviewed-by: Tom Rix <trix@xxxxxxxxxx>
> 
> > 
> > Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> > Signed-off-by: Tianfei Zhang <tianfei.zhang@xxxxxxxxx>

This patch is now good to me.

Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>

> > ---
> > v3: change the name of this feature id to HSSI_SUBSYS and rewrite
> >      the git message.
> > v2: add HSSI introduction and the git repo of Feature ID table.
> > ---
> >   drivers/uio/uio_dfl.c | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/uio/uio_dfl.c b/drivers/uio/uio_dfl.c
> > index 89c0fc7b0cbc..8f39cc8bb034 100644
> > --- a/drivers/uio/uio_dfl.c
> > +++ b/drivers/uio/uio_dfl.c
> > @@ -45,9 +45,11 @@ static int uio_dfl_probe(struct dfl_device *ddev)
> >   }
> >   #define FME_FEATURE_ID_ETH_GROUP	0x10
> > +#define FME_FEATURE_ID_HSSI_SUBSYS	0x15
> >   static const struct dfl_device_id uio_dfl_ids[] = {
> >   	{ FME_ID, FME_FEATURE_ID_ETH_GROUP },
> > +	{ FME_ID, FME_FEATURE_ID_HSSI_SUBSYS },
> >   	{ }
> >   };
> >   MODULE_DEVICE_TABLE(dfl, uio_dfl_ids);