Re: [PATCH v1 8/9] arm64: dts: qcom: sm8350: Power up dispcc using MMCX regulator

[Dmitry Baryshkov]

On 29/04/2022 18:12, Robert Foss wrote:
> Add regulator controlling MMCX power domain to be used by display clock
> controller on SM8350.

NAK. rgulator-fixed-domain is deprecated and is going to be removed shortly.

> Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/sm8350.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index c0137bdcf94b..c49735d1b458 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -278,6 +278,14 @@ memory@80000000 {
>   		reg = <0x0 0x80000000 0x0 0x0>;
>   	};
>   
> +	mmcx_reg: mmcx-reg {
> +		compatible = "regulator-fixed-domain";
> +		power-domains = <&rpmhpd SM8350_MMCX>;
> +		required-opps = <&rpmhpd_opp_nom>;
> +		regulator-name = "MMCX";
> +		regulator-always-on;
> +	};
> +
>   	pmu {
>   		compatible = "arm,armv8-pmuv3";
>   		interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;


--
With best wishes
Dmitry