Re: [PATCH] drm/amdgpu: simplify the return expression of navi10_ih_hw_init()

From: Alex Deucher
Date: Fri Apr 29 2022 - 11:18:11 EST


Applied. Thanks!

On Fri, Apr 29, 2022 at 1:50 AM <cgel.zte@xxxxxxxxx> wrote:
>
> From: Minghao Chi <chi.minghao@xxxxxxxxxx>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
> Signed-off-by: Minghao Chi <chi.minghao@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
> index 97201ab0965e..4b5396d3e60f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
> +++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
> @@ -593,14 +593,9 @@ static int navi10_ih_sw_fini(void *handle)
>
> static int navi10_ih_hw_init(void *handle)
> {
> - int r;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - r = navi10_ih_irq_init(adev);
> - if (r)
> - return r;
> -
> - return 0;
> + return navi10_ih_irq_init(adev);
> }
>
> static int navi10_ih_hw_fini(void *handle)
> --
> 2.25.1
>
>