Re: [PATCH 06/37] speakup: add HAS_IOPORT dependency for SPEAKUP_SERIALIO

From: Samuel Thibault
Date: Fri Apr 29 2022 - 10:39:52 EST


Niklas Schnelle, le ven. 29 avril 2022 15:50:09 +0200, a ecrit:
> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. SPEAKUP_SERIALIO thus needs to depend on HAS_IOPORT.
>
> Co-developed-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Signed-off-by: Niklas Schnelle <schnelle@xxxxxxxxxxxxx>

Reviewed-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

> ---
> drivers/accessibility/speakup/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/accessibility/speakup/Kconfig b/drivers/accessibility/speakup/Kconfig
> index 07ecbbde0384..e84fb617acc4 100644
> --- a/drivers/accessibility/speakup/Kconfig
> +++ b/drivers/accessibility/speakup/Kconfig
> @@ -46,6 +46,7 @@ if SPEAKUP
> config SPEAKUP_SERIALIO
> def_bool y
> depends on ISA || COMPILE_TEST
> + depends on HAS_IOPORT
>
> config SPEAKUP_SYNTH_ACNTSA
> tristate "Accent SA synthesizer support"
> --
> 2.32.0
>

--
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.